Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
On Sat Aug 24 19:22:08 2024 +0000, Elizabeth Figura wrote:
Patch 1/4 still needs to be merged into 2/4. The BroadcastSystemMessage() calls seem to have been inadvertently removed in 2/4, and the split isn't quite complete—it still introduces DBT_DEVTYP_HANDLE support in plugplay_send_event(). Ideally separating the new_event() helper would also be a separate commit, so that you're not moving code and changing it at the same time. Hm, the `BroadcastSystemMessage` calls wouldn't work since the \`DBT_BROADCAST_DEVICEINTERFACE\` struct needs to be first constructed. That being said, I have tried to added code that does that to 1/4. 1/4 also shouldn't have any `DBT_DEVTYP_HANDLE` related code anymore, let me know if that works.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79913
participants (1)
-
Vibhav Pant (@vibhavp)