Re: [PATCH v2 0/1] MR4233: winmm: Fix pszSound allocation in PlaySound_Alloc().

8 Nov 2023


      Huw Davies (@huw) commented about dlls/winmm/playsound.c:
...
else
         {
             UNICODE_STRING usBuffer;
-            RtlCreateUnicodeStringFromAsciiz(&usBuffer, pszSound);
-            wps->pszSound = usBuffer.Buffer;
+            if (!RtlCreateUnicodeStringFromAsciiz(&usBuffer, pszSound)) goto oom_error;
+            wps->pszSound = wcsdup(usBuffer.Buffer);
+            HeapFree(GetProcessHeap(), 0, usBuffer.Buffer);
```suggestion:-0+0
            RtlFreeUnicodeString(&usBuffer);
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4233#note_51460

Huw Davies (＠huw)

tags

participants (1)