[PATCH 0/2] MR1245: comctl32:edit test fixes for flaky failures (message sequences)
From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/comctl32/tests/edit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/comctl32/tests/edit.c b/dlls/comctl32/tests/edit.c index 5f23fff2c9c..62ed66b755e 100644 --- a/dlls/comctl32/tests/edit.c +++ b/dlls/comctl32/tests/edit.c @@ -3445,6 +3445,7 @@ static void test_change_focus(void) SetWindowLongPtrA(hwnd, GWLP_USERDATA, (LONG_PTR)oldproc); SetCursorPos(400, 400); + while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg); SetFocus(parent_wnd); flush_sequences(sequences, NUM_MSG_SEQUENCES); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1245
From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/comctl32/tests/edit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/comctl32/tests/edit.c b/dlls/comctl32/tests/edit.c index 62ed66b755e..7f6ad866c92 100644 --- a/dlls/comctl32/tests/edit.c +++ b/dlls/comctl32/tests/edit.c @@ -3623,6 +3623,7 @@ static void test_ime(void) /* Test IME messages when EIMES_GETCOMPSTRATONCE is not set */ old_proc = (WNDPROC)SetWindowLongPtrA(hwnd, GWLP_WNDPROC, (LONG_PTR)edit_ime_subclass_proc); SetWindowLongPtrA(hwnd, GWLP_USERDATA, (LONG_PTR)old_proc); + while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg); himc = ImmGetContext(hwnd); ret = ImmSetCompositionStringA(himc, SCS_SETSTR, "Wine", 4, NULL, 0); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1245
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=125719 Your paranoid android. === debian11 (32 bit report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit ar:MA report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit de report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit fr report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit he:IL report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit hi:IN report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit ja:JP report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11 (32 bit zh:CN report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11b (32 bit WoW report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds === debian11b (64 bit WoW report) === comctl32: edit.c:3454: Test succeeded inside todo block: Set focus: marked "todo_wine" but succeeds
We have flush_events() helpers duplicate across source files in comctl32/tests. Maybe we could reuse that, by moving them to msg.h? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1245#note_12997
participants (4)
-
Jinoh Kang -
Jinoh Kang (＠iamahuman)
-
Marvin -
Nikolay Sivov (＠nsivov)