[PATCH v3 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)

[Fabian Maurer (＠DarkShadow44)]

--
  v3: gdiplus: Prevent uninitializd memory access (Coverity)
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

[PATCH v3 1/1] gdiplus: Prevent uninitializd memory access (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

---
 dlls/gdiplus/metafile.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c
index eb8b4197f3f..4ad28fde48d 100644
--- a/dlls/gdiplus/metafile.c
+++ b/dlls/gdiplus/metafile.c
@@ -3404,6 +3404,8 @@ GpStatus WINGDIPAPI GdipPlayMetafileRecord(GDIPCONST GpMetafile *metafile,
                 {
                     if (flags & 0x800) /* P */
                     {
+                        points[0].X = fill->PointData.pointsR[0].X;
+                        points[0].Y = fill->PointData.pointsR[0].Y;
                         for (i = 1; i < fill->Count; i++)
                         {
                             points[i].X = points[i - 1].X + fill->PointData.pointsR[i].X;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

[Nikolay Sivov (＠nsivov)]

This one is broken after recent 69d815407d99667e2565e268629d909fe50b2b30. We'll need to examine this change more carefully, it didn't switch to equivalent zero-ing calls.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55654