[PATCH 0/1] MR7184: vbscript: Correct resource text for VBSE_PARAMETER_NOT_OPTIONAL

[Alistair Leslie-Hughes (＠alesliehughes)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7184

[PATCH 1/1] vbscript: Correct resource text for VBSE_PARAMETER_NOT_OPTIONAL

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/vbscript/vbscript.rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/vbscript/vbscript.rc b/dlls/vbscript/vbscript.rc
index f90e6668bcb..b874b74280c 100644
--- a/dlls/vbscript/vbscript.rc
+++ b/dlls/vbscript/vbscript.rc
@@ -50,7 +50,7 @@ STRINGTABLE
     VBSE_NAMED_ARGS_NOT_SUPPORTED      "Object doesn't support named arguments"
     VBSE_LOCALE_SETTING_NOT_SUPPORTED  "Object doesn't support current locale setting"
     VBSE_NAMED_PARAM_NOT_FOUND         "Named argument not found"
-    VBSE_PARAMETER_NOT_OPTIONAL        "Named argument not found"
+    VBSE_PARAMETER_NOT_OPTIONAL        "Parameter not optional"
     VBSE_FUNC_ARITY_MISMATCH           "Wrong number of arguments or invalid property assignment"
     VBSE_NOT_ENUM                      "Object not a collection"
     VBSE_INVALID_DLL_FUNCTION_NAME     "Specified DLL function not found"
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7184

[PATCH 1/1] vbscript: Correct resource text for VBSE_PARAMETER_NOT_OPTIONAL

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=151010

Your paranoid android.


=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1586: Test failed: Unexpected time 1001, expected around 500

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/vbscript.rc:
> VBSE_NAMED_ARGS_NOT_SUPPORTED      "Object doesn't support named arguments"
>      VBSE_LOCALE_SETTING_NOT_SUPPORTED  "Object doesn't support current locale setting"
>      VBSE_NAMED_PARAM_NOT_FOUND         "Named argument not found"
> -    VBSE_PARAMETER_NOT_OPTIONAL        "Named argument not found"
> +    VBSE_PARAMETER_NOT_OPTIONAL        "Parameter not optional"

It probably doesn't matter much, but it's visible to the script and native uses "Argument not optional".

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7184#note_93021