Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/setupapi/devinst.c:
> {
>              if (procnameW)
>              {
> -                procname = strdupWtoA(procnameW + 1);
> +                procname = UnicodeToMultiByte(procnameW + 1, CP_ACP);
>                  coinst_proc = (void *)GetProcAddress(module, procname);
> -                heap_free(procname);
> +                MyFree(procname);

It's hard for me to feel like this is an improvement, when we are now adding an extra parameter to every call, and also using some undocumented Windows functions that, to the reader, might have some obscure different semantics.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_28895