Re: [PATCH v7 0/1] MR10174: bcryptprimitives: Abort if `ProcessPrng` fails
25 Feb
2026
25 Feb
'26
6:54 p.m.
I don't really understand why we're doing this in the first place. The documentation often claims things that are wrong especially as related to edge cases. If there's not a foreseeable case where RtlGenRandom() could fail (and I don't think memory exhaustion counts as foreseeable either) then I don't think it's worth touching.
Yeah. And I honestly don't see how even memory exhaustion is a bad case here, there is no new allocations on the way. And if page in for previously allocated buffer space fails the process will be OOM killed without our abort. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10174#note_130523
8
Age (days ago)
8
Last active (days ago)
0 comments
1 participants
participants (1)
-
Paul Gofman (@gofman)