[PATCH 0/1] MR7753: configure.ac: avoid problems with -Werror=return-type in check
Reported-By: Alexander Leithner <aleithner(a)level101.at> Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7753
From: Marcus Meissner <marcus(a)jet.franken.de> Reported-By: Alexander Leithner <aleithner(a)level101.at> Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a6c048132d4..d919b9dc30f 100644 --- a/configure.ac +++ b/configure.ac @@ -1997,7 +1997,7 @@ then *) AC_CACHE_CHECK([for working -mabi=ms], ac_cv_mabi_ms, [CFLAGS="$CFLAGS -mabi=ms" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdarg.h> -int a(int b, ...) { __builtin_ms_va_list list; __builtin_ms_va_start(list,b); }]])], +int a(int b, ...) { __builtin_ms_va_list list; __builtin_ms_va_start(list,b); return 0; }]])], [ac_cv_mabi_ms=yes],[ac_cv_mabi_ms=no]) CFLAGS=$saved_CFLAGS]) AS_VAR_IF([ac_cv_mabi_ms],[yes], -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7753
Dmitry Timoshkov (@dmitry) commented about configure.ac:
*) AC_CACHE_CHECK([for working -mabi=ms], ac_cv_mabi_ms, [CFLAGS="$CFLAGS -mabi=ms" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdarg.h> -int a(int b, ...) { __builtin_ms_va_list list; __builtin_ms_va_start(list,b); }]])], +int a(int b, ...) { __builtin_ms_va_list list; __builtin_ms_va_start(list,b); return 0; }]])],
Wouldn't it be cleaner to use void return type? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7753#note_100061
participants (3)
-
Dmitry Timoshkov (@dmitry) -
Marcus Meissner -
Marcus Meissner (@msmeissn)