[PATCH 0/1] MR1483: explorer: Put the calling convention inside the function pointer parentheses.

[Alex Henrie (＠alexhenrie)]

As required by MSVC.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1483

[PATCH 1/1] explorer: Put the calling convention inside the function pointer parentheses.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

As required by MSVC.
---
 programs/explorer/startmenu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/programs/explorer/startmenu.c b/programs/explorer/startmenu.c
index 3173ae21fc6..b46bd068220 100644
--- a/programs/explorer/startmenu.c
+++ b/programs/explorer/startmenu.c
@@ -371,8 +371,8 @@ static void fill_menu(struct menu_item* item)
 
 static void run_dialog(void)
 {
-    void WINAPI (*pRunFileDlg)(HWND hWndOwner, HICON hIcon, LPCSTR lpszDir,
-                               LPCSTR lpszTitle, LPCSTR lpszDesc, DWORD dwFlags);
+    void (WINAPI *pRunFileDlg)(HWND owner, HICON icon, const char *dir,
+                               const char *title, const char *desc, DWORD flags);
     HMODULE hShell32;
 
     hShell32 = LoadLibraryW(L"shell32");
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1483

[PATCH 1/1] explorer: Put the calling convention inside the function pointer parentheses.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126602

Your paranoid android.


=== debian11 (32 bit report) ===

d3d8:
stateblock: Timeout
visual: Timeout

d3d9:
d3d9ex: Timeout
device: Timeout
stateblock: Timeout
visual: Timeout

d3dcompiler_43:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_46:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_47:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3drm:
d3drm: Timeout

Report validation errors:
d3drm:vector timeout

=== debian11 (build log) ===

WineRunWineTest.pl:error: The task timed out