[PATCH v2 0/1] MR4676: server: Use the desktop cursor as the default thread input cursor.

[Rémi Bernon]

We are preferring the thread input cursor over the global desktop
cursor, but if the thread input has no cursor yet, for instance when
thread is attached to another thread without a message queue yet,
it will end up being invisible.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55961

--
  v2: server: Use the desktop cursor as the default thread input cursor.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

[PATCH v2 1/1] server: Use the desktop cursor as the default thread input cursor.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55961
---
 server/queue.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/server/queue.c b/server/queue.c
index 0558bd111f9..6ab3ffe7a2b 100644
--- a/server/queue.c
+++ b/server/queue.c
@@ -275,6 +275,7 @@ static struct thread_input *create_thread_input( struct thread *thread )
             return NULL;
         }
         memcpy( input->desktop_keystate, input->desktop->keystate, sizeof(input->desktop_keystate) );
+        input->cursor = input->desktop->cursor.handle;
     }
     return input;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

[PATCH v2 1/1] server: Use the desktop cursor as the default thread input cursor.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=141406

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
cursoricon.c:2503: Test failed: wrong thread cursor 3710086/0000000000000000

[Rémi Bernon]

Trying a different way instead, less changes and perhaps less controversial?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4676#note_56292

[Rémi Bernon]

Hmm, of course it breaks the tests.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4676#note_56294