Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c:
> +            }
> +        }
> +
> +        for (i = 0; i < retain_range_count; ++i) {
> +            if (retain_range_array[i].OffsetInOldFile <= old_file_size
> +                && (retain_range_array[i].OffsetInOldFile + retain_range_array[i].LengthInBytes) <= old_file_size)
> +            {
> +                memset(&old_file_buffer[retain_range_array[i].OffsetInOldFile],
> +                       0,
> +                       retain_range_array[i].LengthInBytes);
> +                result = NORMALIZE_RESULT_SUCCESS;
> +            }
> +        }
> +    }
> +
> +    return result + 1;
> Why are we adding one here? That doesn't look right.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45764