[PATCH 0/2] MR7155: mfsrcsnk: Fix a couple of memory leaks.

[Conor McCarthy (＠cmccarthy)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7155

[PATCH 1/2] mfsrcsnk: Release object queue objects on destruction.

[Conor McCarthy]

From: Conor McCarthy <cmccarthy(a)codeweavers.com>

---
 dlls/mfsrcsnk/media_source.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mfsrcsnk/media_source.c b/dlls/mfsrcsnk/media_source.c
index ac5f013d9cd..c4c05e647ae 100644
--- a/dlls/mfsrcsnk/media_source.c
+++ b/dlls/mfsrcsnk/media_source.c
@@ -80,7 +80,7 @@ struct object_entry
 
 static void object_entry_destroy(struct object_entry *entry)
 {
-    if (entry->object) IUnknown_AddRef( entry->object );
+    if (entry->object) IUnknown_Release( entry->object );
     free(entry);
 }
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/7155

[PATCH 2/2] mfsrcsnk: Release the async request popped sample after sending it.

[Conor McCarthy]

From: Conor McCarthy <cmccarthy(a)codeweavers.com>

---
 dlls/mfsrcsnk/media_source.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/mfsrcsnk/media_source.c b/dlls/mfsrcsnk/media_source.c
index c4c05e647ae..5fe5a4af6e7 100644
--- a/dlls/mfsrcsnk/media_source.c
+++ b/dlls/mfsrcsnk/media_source.c
@@ -812,7 +812,10 @@ static HRESULT media_stream_async_request(struct media_stream *stream, IMFAsyncR
     if (source->state == SOURCE_SHUTDOWN)
         hr = MF_E_SHUTDOWN;
     else if (source->state == SOURCE_RUNNING && SUCCEEDED(hr = object_queue_pop(&stream->samples, (IUnknown **)&sample)))
+    {
         media_stream_send_sample(stream, sample, token);
+        IMFSample_Release(sample);
+    }
     else if (SUCCEEDED(hr = object_queue_push(&stream->tokens, token)) && source->state == SOURCE_RUNNING)
         queue_media_source_read(source);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7155

[PATCH 0/2] MR7155: mfsrcsnk: Fix a couple of memory leaks. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7155