[PATCH 0/1] MR1138: gitlab: Add winetest checksums to the build artifacts.
From: Francois Gouget <fgouget(a)codeweavers.com> GitLab does not put the artifacts in place atomically. The checksums allow downloaders to make sure their downloads are complete. --- TestBot job 125179 got a successful download of winetest64-latest.exe yet the resulting binary was incomplete (28MB instead of 51MB) and unrunnable. But currently the TestBot has no way to know the binary was invalid. Publishing the checksums will make it easy to detect binary changes and to check their integrity. --- tools/gitlab/build.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/gitlab/build.yml b/tools/gitlab/build.yml index 6bc253b2c77..100a943e998 100644 --- a/tools/gitlab/build.yml +++ b/tools/gitlab/build.yml @@ -74,7 +74,11 @@ build-winetest: name: winetest paths: - winetest.exe + - winetest.exe.sha256 - winetest64.exe + - winetest64.exe.sha256 script: - mv usr/local/lib/wine/i386-windows/winetest.exe winetest.exe + - sha256sum winetest.exe >winetest.exe.sha256 - mv usr/local/lib/wine/x86_64-windows/winetest.exe winetest64.exe + - sha256sum winetest64.exe >winetest64.exe.sha256 -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1138
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=125255 Your paranoid android. === debian11 (build log) === Task: Could not create the win32 wineprefix: Failed to disable the crash dialogs: Task: WineTest did not produce the win32 report
The test-linux-32 CI failure is a known bug (the TestBot knows not to report it as a new failure): https://bugs.winehq.org//show_bug.cgi?id=53167 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1138#note_11894
On Fri Oct 21 17:36:02 2022 +0000, **** wrote:
Marvin replied on the mailing list: ``` Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=125255 Your paranoid android. === debian11 (build log) === Task: Could not create the win32 wineprefix: Failed to disable the crash dialogs: Task: WineTest did not produce the win32 report ``` All 32-bit wineprefix creation is broken since MR1089. See: https://bugs.winehq.org//show_bug.cgi?id=53829
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1138#note_11895
This merge request was closed by Francois Gouget. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1138
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Marvin