[PATCH 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat().

[Paul Gofman (＠gofman)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53429

As the bug states, the test is failing on Wine / Intel GPU. The test was added in commit 83cbcdefa3f55afc449b6be51e215c4f646869f4 which was a test for cc8d8b5ee33561e984d4abe4112ddd6324f77115 (opengl32: Prioritize stencil check over depth check in wglChoosePixelFormat()). The motivation under that change was to avoid the situation when we erroneously return the no-stencil format (which was breaking a game) and not vice versa. This specific test was probably added for completeness. I don't have a Windows Intel GPU machine to check how it looks like there but it seems to me that this aspect (returning 0 depth stencil instead of 8 when no stencil requested) is much less likely to affect things in practice, so just remove the test instead of trying to fix that in Wine on Intel.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/563

[PATCH 1/1] opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat().

[Paul Gofman]

From: Paul Gofman <pgofman(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53429
---
 dlls/opengl32/tests/opengl.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c
index 7d407a1d0b0..57be207b548 100644
--- a/dlls/opengl32/tests/opengl.c
+++ b/dlls/opengl32/tests/opengl.c
@@ -380,12 +380,6 @@ static void test_choosepixelformat(void)
     pfd.cDepthBits = 0;
     pfd.cStencilBits = 0;
 
-    pfd.cDepthBits = 32;
-    ok( test_pfd(&pfd, &ret_fmt), "depth 32, stencil 8 failed.\n" );
-    ok( ret_fmt.cDepthBits >= 24, "Got unexpected cDepthBits %u.\n", ret_fmt.cDepthBits );
-    ok( !ret_fmt.cStencilBits, "Got unexpected cStencilBits %u.\n", ret_fmt.cStencilBits );
-    pfd.cDepthBits = 0;
-
     pfd.cStencilBits = 8;
     ok( test_pfd(&pfd, &ret_fmt), "depth 32, stencil 8 failed.\n" );
     ok( ret_fmt.cStencilBits == 8, "Got unexpected cStencilBits %u.\n", ret_fmt.cStencilBits );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/563

[PATCH 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat(). - approved

[Matteo Bruni (＠Mystral)]

This merge request was approved by Matteo Bruni.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/563