[PATCH v2 0/1] MR5704: makedep: Silence Clang warnings in bison-generated files.
Depending on bison version and Clang config, generated files cause various warnings. In gitlab CI, there is an unused function in wbemprox. I don't see it on newer bison and LLVM, but there are other -Wunused-but-set-variable warning instead. This was partially fixed in upstream bison: https://git.savannah.gnu.org/cgit/bison.git/commit/?id=a166d5450e3f47587b98f... The fix does not take into account MSVC targets, I tried upstreaming a fix for that, with no success: https://savannah.gnu.org/patch/?10420 https://lists.gnu.org/archive/html/bison-patches/2023-11/msg00000.html Together with !5628, this allows enabling `-Werror` in out CI. -- v2: wbemprox: Avoid unused function warning. https://gitlab.winehq.org/wine/wine/-/merge_requests/5704
From: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/wql.y | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wbemprox/wql.y b/dlls/wbemprox/wql.y index ba33396ddeb..541cd2450f0 100644 --- a/dlls/wbemprox/wql.y +++ b/dlls/wbemprox/wql.y @@ -299,6 +299,7 @@ associatorsof: } PARSER_BUBBLE_UP_VIEW( parser, $$, view ); + (void)yysymbol_name; /* avoid unused function warning */ } | TK_ASSOCIATORS TK_OF path TK_WHERE keywordlist { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5704
Thanks for suggestions. I updated the MR with suggested change, it seems simple enough to avoid rising required bison version. I will revisit yynerrs later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5704#note_71215
participants (2)
-
Alexandre Julliard -
Jacek Caban (@jacek)