[PATCH 0/1] MR994: gdi32/tests: Mark tests failing randomly on Windows as flaky.
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51313 --- dlls/gdi32/tests/driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/gdi32/tests/driver.c b/dlls/gdi32/tests/driver.c index 3a300b4dff5..b2d2a0545ff 100644 --- a/dlls/gdi32/tests/driver.c +++ b/dlls/gdi32/tests/driver.c @@ -671,6 +671,7 @@ static void test_D3DKMTCheckOcclusion(void) ShowWindow(hwnd, SW_MINIMIZE); occlusion_desc.hWnd = hwnd; status = pD3DKMTCheckOcclusion(&occlusion_desc); + flaky ok(status == STATUS_SUCCESS, "Got unexpected return code %#lx.\n", status); ShowWindow(hwnd, SW_SHOWNORMAL); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/994
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124693 Your paranoid android. === w10pro64_ar (64 bit report) === gdi32: driver.c:675: Test marked flaky: Got unexpected return code 0xc01e0006. Report validation errors: gdi32:driver returned success despite having failures
All flaky so it's okay. The accounting issues are because the flaky are no longer counted as failures but the TestBot was now updated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/994#note_9935
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/994
participants (4)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Huw Davies (＠huw)
-
Marvin