[PATCH 0/1] MR1960: localspl: Avoid unused variable in fill_builtin_form_info

[Gerald Pfeifer (＠gerald)]

As diagnosed by GCC 13:

    dlls/localspl/provider.c: In function ‘fill_builtin_form_info’:
    dlls/localspl/provider.c:3045:16: warning: ‘res_len’ may be used uninitialized [-Wmaybe-uninitialized]
     3045 |             if (res_len)
          |                ^

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1960

[PATCH 1/1] localspl: Avoid unused variable in fill_builtin_form_info

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

As diagnosed by GCC 13:

    dlls/localspl/provider.c: In function ‘fill_builtin_form_info’:
    dlls/localspl/provider.c:3045:16: warning: ‘res_len’ may be used uninitialized [-Wmaybe-uninitialized]
     3045 |             if (res_len)
          |                ^
---
 dlls/localspl/provider.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/localspl/provider.c b/dlls/localspl/provider.c
index 790d9d64c00..20a4bd884c2 100644
--- a/dlls/localspl/provider.c
+++ b/dlls/localspl/provider.c
@@ -3022,6 +3022,8 @@ static void fill_builtin_form_info( BYTE **base, WCHAR **strings, const struct b
         res_len = LoadStringW( localspl_instance, form->res_id, (WCHAR *)&resource, 0 );
         if (res_len && resource[res_len - 1]) res_len++;
         total_size += (res_len + ARRAY_SIZE(dll_name)) * sizeof(WCHAR);
+    } else {
+        res_len = 0;
     }
 
     if (*used + total_size <= size)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1960

[PATCH 0/1] MR1960: localspl: Avoid uninitialized variable in fill_builtin_form_info

[Huw Davies (＠huw)]

This isn't actually a real problem, however let's just initialise `res_len` in its definition.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1960#note_20910