[PATCH 0/2] MR9262: Revert setting macOS QoS class in main thread.

[Marc-Aurel Zent (＠mzent)]

Server will overwrite this anyways (with also a boosted main thread priority/QoS class).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9262

[PATCH 1/2] Revert "ntdll: Fix runtime availability check for pthread_attr_set_qos_class_np."

[Marc-Aurel Zent]

From: Marc-Aurel Zent <mzent(a)codeweavers.com>

This reverts commit e605bc17a5657814a8f9a99e2a94d3222e03ba9d.
---
 dlls/ntdll/unix/loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/unix/loader.c b/dlls/ntdll/unix/loader.c
index effd15c8fe3..228732e572c 100644
--- a/dlls/ntdll/unix/loader.c
+++ b/dlls/ntdll/unix/loader.c
@@ -2066,7 +2066,7 @@ static void apple_create_wine_thread( void *arg )
     pthread_attr_init( &attr );
     pthread_attr_setdetachstate( &attr, PTHREAD_CREATE_JOINABLE );
     /* Use the same QoS class as the process main thread (user-interactive). */
-    if (&pthread_attr_set_qos_class_np)
+    if (pthread_attr_set_qos_class_np)
         pthread_attr_set_qos_class_np( &attr, QOS_CLASS_USER_INTERACTIVE, 0 );
     if (pthread_create( &thread, &attr, apple_wine_thread, NULL )) exit(1);
     pthread_attr_destroy( &attr );
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/9262

[PATCH 2/2] Revert "ntdll: Set the QoS class of the main Wine thread on macOS."

[Marc-Aurel Zent]

From: Marc-Aurel Zent <mzent(a)codeweavers.com>

This reverts commit ed666db8d8d6afd740a266584a38e08622474821.
---
 dlls/ntdll/unix/loader.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/ntdll/unix/loader.c b/dlls/ntdll/unix/loader.c
index 228732e572c..34e9c0d87e5 100644
--- a/dlls/ntdll/unix/loader.c
+++ b/dlls/ntdll/unix/loader.c
@@ -2065,9 +2065,6 @@ static void apple_create_wine_thread( void *arg )
 
     pthread_attr_init( &attr );
     pthread_attr_setdetachstate( &attr, PTHREAD_CREATE_JOINABLE );
-    /* Use the same QoS class as the process main thread (user-interactive). */
-    if (pthread_attr_set_qos_class_np)
-        pthread_attr_set_qos_class_np( &attr, QOS_CLASS_USER_INTERACTIVE, 0 );
     if (pthread_create( &thread, &attr, apple_wine_thread, NULL )) exit(1);
     pthread_attr_destroy( &attr );
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9262

[Huw Davies (＠huw)]

Any reason not to squash these together? As it stands you'll be leaving things in a broken state after the first commit.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9262#note_119438