[PATCH 0/1] MR2892: wined3d: Fix uninitialized variable warning.

[Davide Beatrici (＠davidebeatrici)]

```c
dlls/wined3d/context_vk.c:2377:42: warning: ‘null_binding’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 2377 |                     *null_buffer_binding = b->binding = null_binding;
      |                     ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2892

[PATCH 1/1] wined3d: Fix uninitialized variable warning.

[Davide Beatrici]

From: Davide Beatrici <git(a)davidebeatrici.dev>

dlls/wined3d/context_vk.c:2377:42: warning: ‘null_binding’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 2377 |                     *null_buffer_binding = b->binding = null_binding;
      |                     ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
---
 dlls/wined3d/context_vk.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/dlls/wined3d/context_vk.c b/dlls/wined3d/context_vk.c
index 10713985e7e..a63cea79279 100644
--- a/dlls/wined3d/context_vk.c
+++ b/dlls/wined3d/context_vk.c
@@ -2337,13 +2337,13 @@ static bool wined3d_context_vk_update_graphics_pipeline_key(struct wined3d_conte
         {
             struct wined3d_shader_signature_element *element;
             struct wined3d_shader_signature *signature;
-            uint32_t null_binding, location;
+            uint32_t location;
 
             for (i = 0; i < ARRAY_SIZE(state->streams); ++i)
             {
                 if (!state->streams[i].buffer)
                 {
-                    null_binding = i;
+                    a->binding = i;
                     break;
                 }
             }
@@ -2366,7 +2366,6 @@ static bool wined3d_context_vk_update_graphics_pipeline_key(struct wined3d_conte
 
                     a = &key->attributes[attribute_count++];
                     a->location = location;
-                    a->binding = null_binding;
                     a->format = vk_format_from_component_type(element->component_type);
                     a->offset = 0;
                 }
@@ -2374,7 +2373,7 @@ static bool wined3d_context_vk_update_graphics_pipeline_key(struct wined3d_conte
                 if (mask != (~stream_info.use_map & vertex_shader->reg_maps.input_registers))
                 {
                     b = &key->bindings[binding_count++];
-                    *null_buffer_binding = b->binding = null_binding;
+                    *null_buffer_binding = b->binding = a->binding;
                     b->stride = 0;
                     b->inputRate = VK_VERTEX_INPUT_RATE_VERTEX;
                 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2892

[Davide Beatrici (＠davidebeatrici)]

```c
../dlls/wined3d/context_vk.c:2346:32: error: 'a' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2346 |                     a->binding = i;
      |                     ~~~~~~~~~~~^~~
```

I don't see this warning locally, but I just realized `a` is in a `for` loop right below.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2892#note_33623