[PATCH v3 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check.

[Francois Gouget (＠fgouget)]

--
  v3: d3d12/tests: Don't check the refcount after releasing the dxgi adapter.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1965

[PATCH v3 1/1] d3d12/tests: Don't check the refcount after releasing the dxgi adapter.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

The refcount is >= 1 on Windows 10 1709 and 1809 but 0 on more recent
versions. So its value is not really important.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54299
---
 dlls/d3d12/tests/d3d12.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/d3d12/tests/d3d12.c b/dlls/d3d12/tests/d3d12.c
index 33c8ad8dfff..5d3f8a36a2d 100644
--- a/dlls/d3d12/tests/d3d12.c
+++ b/dlls/d3d12/tests/d3d12.c
@@ -884,8 +884,7 @@ static void test_create_device(void)
     ok(refcount == 1, "Got unexpected refcount %lu.\n", refcount);
     hr = D3D12CreateDevice((IUnknown *)adapter, D3D_FEATURE_LEVEL_11_0, &IID_ID3D12Device, (void **)&device);
     ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
-    refcount = IDXGIAdapter_Release(adapter);
-    ok(refcount >= 1, "Got unexpected refcount %lu.\n", refcount);
+    IDXGIAdapter_Release(adapter);
     adapter = NULL;
 
     luid = ID3D12Device_GetAdapterLuid(device);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1965

[Francois Gouget (＠fgouget)]

v3: Drop the refcount check after releasing the DXGI adapter.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1965#note_21952

[Francois Gouget (＠fgouget)]

On Tue Jan 17 19:35:38 2023 +0000, Francois Gouget wrote:
> I see.
> * test.winehq.org shows that there is no failure in Wine which means it
> consistently returns refcount >= 1.
> * But there was no failure for this test in the 10 TestBot runs. However
> looking closer it seems that's because the test is systematically
> skipped there due to 'Failed to create device'.
> * There was no failure on the GitLab CI either and no skipped traces.
> However I believe the 'skipped' traces are silenced there so the tests
> are probably still not run.
> So then adding a todo_wine would probably fix the test on both Windows
> and Wine.
> Fixed in v2 (and even more so in v3).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1965#note_21953

[PATCH v3 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check. - approved

[Henri Verbeet (＠hverbeet)]

This merge request was approved by Henri Verbeet.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1965

[PATCH v3 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check. - approved

[Jan Sikorski (＠jsikorski)]

This merge request was approved by Jan Sikorski.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1965