[PATCH 0/1] MR8992: mountmgr.sys: Do not create empty registry nodes for serial or parallel devices.

[Janne Kekkonen (＠Janne)]

Empty registry node for parallel devices will cause Realterm to crash.

Wine-bug:https://bugs.winehq.org/show_bug.cgi?id=58598

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8992

[PATCH 1/1] mountmgr.sys: Do not create registry nodes if there are not serial or parallel devices.

[Janne Kekkonen]

From: Janne Kekkonen <janne.kekkonen(a)gmail.com>

Empty registry node for parallel devices will cause Realterm to crash.

Wine-bug:https://bugs.winehq.org/show_bug.cgi?id=58598
---
 dlls/mountmgr.sys/device.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c
index ba019cdb13d..a7d569b9cd6 100644
--- a/dlls/mountmgr.sys/device.c
+++ b/dlls/mountmgr.sys/device.c
@@ -1986,6 +1986,9 @@ static void create_port_devices( DRIVER_OBJECT *driver, const char *devices )
     DWORD port_len, type, size;
     int i, n;
 
+    /*If no devices do not create registry entry*/
+    if (strlen(devices)==0) return;
+
     if (driver == serial_driver)
     {
         dosdev_fmt = "com%u";
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8992

[Alexandre Julliard (＠julliard)]

We'd still want to create the key for the case of user-defined ports.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8992#note_116276