Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
On Sun Jan 22 22:25:54 2023 +0000, Thomas Csovcsity wrote:
Sure, that it can be done. Other parts of the code use goto too. I also used already goto in kernel and drivers. ATM i am not able to think about a function which would make it easier. If i use early return from function, i think it makes no difference, but i plan to use a helper function to keep UrlFixup shorter. Any suggestion about the structure is well come, because i think i am blind to other and better ways. It's not cargo-cult avoidance of goto (although in general I think there are only a few situations where it's the most idiomatic choice), but I think using a helper is a lot more readable in patterns like this.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21345
participants (1)
-
Zebediah Figura (@zfigura)