[PATCH 0/1] MR1805: dswave: Don't force a calling convention on internal functions.

[Alex Henrie (＠alexhenrie)]

I missed this one in merge request !1489.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1805

[PATCH 1/1] dswave: Don't force a calling convention on internal functions.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/dswave/dswave.c         | 2 +-
 dlls/dswave/dswave_private.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dswave/dswave.c b/dlls/dswave/dswave.c
index 1b83d5ab053..e6d85d738fe 100644
--- a/dlls/dswave/dswave.c
+++ b/dlls/dswave/dswave.c
@@ -175,7 +175,7 @@ static const IPersistStreamVtbl persiststream_vtbl = {
 };
 
 /* for ClassFactory */
-HRESULT WINAPI create_dswave(REFIID lpcGUID, void **ppobj)
+HRESULT create_dswave(REFIID lpcGUID, void **ppobj)
 {
     IDirectMusicWaveImpl *obj;
     HRESULT hr;
diff --git a/dlls/dswave/dswave_private.h b/dlls/dswave/dswave_private.h
index 5b5eb7a937d..dfd8ed6f51c 100644
--- a/dlls/dswave/dswave_private.h
+++ b/dlls/dswave/dswave_private.h
@@ -42,7 +42,7 @@
 /*****************************************************************************
  * ClassFactory
  */
-extern HRESULT WINAPI create_dswave(REFIID lpcGUID, void **ret_iface) DECLSPEC_HIDDEN;
+extern HRESULT create_dswave(REFIID lpcGUID, void **ret_iface) DECLSPEC_HIDDEN;
 
 /**********************************************************************
  * Dll lifetime tracking declaration for dswave.dll
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1805

[PATCH 0/1] MR1805: dswave: Don't force a calling convention on internal functions. - approved

[Michael Stefaniuc (＠mstefani)]

This merge request was approved by Michael Stefaniuc.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1805

[Michael Stefaniuc (＠mstefani)]

While we're in the freeze dswave is basically unused. So this is safe.
See dlls/dswave/dswave.c line 151:

    /* Without the private interface the implementation should go to dmime/segment.c */

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1805#note_19571