[PATCH 0/1] MR8299: winetest: Filter out some CI environment variables.

[Bernhard Übelacker]

This is an alternative location to filter out this environment variables, see merge request !8292 for details.

Doing this in winetest would have the advantage to protect all tests run by it, not just kernel32:process.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8299

[PATCH 1/1] winetest: Filter out some CI environment variables.

[Bernhard Übelacker]

From: Bernhard Übelacker <bernhardu(a)mailbox.org>

---
 programs/winetest/main.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/programs/winetest/main.c b/programs/winetest/main.c
index 755e4eb6e2c..eefea04a95b 100644
--- a/programs/winetest/main.c
+++ b/programs/winetest/main.c
@@ -1701,6 +1701,16 @@ int __cdecl main( int argc, char *argv[] )
             SetEnvironmentVariableA( "WINETEST_DEBUG", "1" );
             SetEnvironmentVariableA( "WINETEST_INTERACTIVE", "0" );
             SetEnvironmentVariableA( "WINETEST_REPORT_SUCCESS", "0" );
+
+            /* This environment variables contain the patch authors name,
+               which may contain extended ascii or UTF-8 characters.
+               At least the kernel32:process test fails on Windows because
+               of this, as CreateProcessA with a user supplied environment
+               could not replicate these variable contents.
+               And the failure message makes the CI fail in qemu-agent.py with a:
+               UnicodeDecodeError: 'utf-8' codec can't decode byte ... */
+            SetEnvironmentVariableA( "CI_COMMIT_AUTHOR", NULL );
+            SetEnvironmentVariableA( "GITLAB_USER_NAME", NULL );
         }
         if (junit)
         {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8299

[PATCH 0/1] MR8299: winetest: Filter out some CI environment variables. - approved

[Jinoh Kang (＠iamahuman)]

This merge request was approved by Jinoh Kang.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8299

[eric pouech (＠epo)]

for bugzilla housekeeping https://bugs.winehq.org/show_bug.cgi?id=55019

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8299#note_106460

[Alexandre Julliard (＠julliard)]

This should most likely be done in the CI script.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8299#note_107290