Re: [PATCH v4 0/1] MR722: wined3d:Set desc.depth To TRUE For Unrecognized Depth Buffer Type
13 Sep
2022
13 Sep
'22
11:23 a.m.
What do the linked test results show? I assume you made those runs with the changed tests as in the patch. If so, it seems that this proposed behavior is correct for d3d8, but not for d3d9? If that's right, we should probably include this distinction in the implementation; and the d3d9 test should be changed to reflect actual behavior. As an aside, the commit could be improved in terms of style: Don't Capitalize Every Word, fix oddly placed whitespace, and drop the `<br>`. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/722#note_8315
1187
Age (days ago)
1187
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jan Sikorski (@jsikorski)