[PATCH 0/1] MR5960: ntdll: Remove superflous null check (coverity)

[Fabian Maurer (＠DarkShadow44)]

It's dereferenced later in create_window_handle anyways

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

[PATCH 1/1] ntdll: Remove superflous null check (coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

It's dereferenced later in create_window_handle anyways
---
 dlls/win32u/window.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/win32u/window.c b/dlls/win32u/window.c
index 841ab220074..8c510ec9729 100644
--- a/dlls/win32u/window.c
+++ b/dlls/win32u/window.c
@@ -5174,7 +5174,7 @@ HWND WINAPI NtUserCreateWindowEx( DWORD ex_style, UNICODE_STRING *class_name,
     cs.style      = style;
     cs.dwExStyle  = ex_style;
     cs.lpszName   = window_name ? window_name->Buffer : NULL;
-    cs.lpszClass  = class_name ? class_name->Buffer : NULL;
+    cs.lpszClass  = class_name->Buffer;
     cs.x  = x;
     cs.y  = y;
     cs.cx = cx;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

[Fabian Maurer (＠DarkShadow44)]

Any news?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960#note_76153

[Fabian Maurer (＠DarkShadow44)]

@jacek Since you made the original code, would you mind reviewing this?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960#note_77428

[Jacek Caban (＠jacek)]

It seems fine to me, but the commit message should mention win32u, not ntdll.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960#note_77676