[PATCH 0/1] MR3937: d3dx9_36: Trace pointer not the object

[Alistair Leslie-Hughes (＠alesliehughes)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3937

[PATCH 1/1] d3dx9_36: Trace pointer not the object

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/d3dx9_36/mesh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c
index 47a0cadde67..d56333e4888 100644
--- a/dlls/d3dx9_36/mesh.c
+++ b/dlls/d3dx9_36/mesh.c
@@ -6464,7 +6464,7 @@ error:
 
 HRESULT WINAPI D3DXValidMesh(ID3DXMesh *mesh, const DWORD *adjacency, ID3DXBuffer **errors_and_warnings)
 {
-    FIXME("(%p, %p, %p): stub\n", mesh, adjacency, *errors_and_warnings);
+    FIXME("(%p, %p, %p): stub\n", mesh, adjacency, errors_and_warnings);
 
     return E_NOTIMPL;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3937

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/mesh.c:
> HRESULT WINAPI D3DXValidMesh(ID3DXMesh *mesh, const DWORD *adjacency, ID3DXBuffer **errors_and_warnings)
>  {
> -    FIXME("(%p, %p, %p): stub\n", mesh, adjacency, *errors_and_warnings);
> +    FIXME("(%p, %p, %p): stub\n", mesh, adjacency, errors_and_warnings);

Can you please update the message while at it? Like "mesh %p, ...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3937#note_46801

[Matteo Bruni (＠Mystral)]

Please use "d3dx9:" as subject prefix, ideally also mention D3DXValidMesh() in the subject.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3937#note_46802