Re: [PATCH v3 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
4 Aug
2023
4 Aug
'23
8:16 p.m.
It doesn't matter much if the handle is invalid, as the PutWorkItem call will just fail.
But the handle could in theory be reallocated for a different queue. Also, if queues are supposed to be refcounted, it looks quite wrong that a thread which doesn't have a reference to a handle is accessing it; that's the sort of thing that generally causes memory errors. It might be the case that our current implementation is preventing any of this from being a problem in practice, but it's fragile and unidiomatic, and it is rather confusing to anyone reading the code; it looks like an error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3491#note_41425
866
Age (days ago)
866
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zebediah Figura (@zfigura)