[PATCH 0/1] MR1803: ntoskrnl/tests: Ignore CONFIGFLAG_FINISH_INSTALL on the child device.

[Zebediah Figura (＠zfigura)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53976

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1803

[PATCH 1/1] ntoskrnl/tests: Ignore CONFIGFLAG_FINISH_INSTALL on the child device.

[Zebediah Figura]

From: Zebediah Figura <zfigura(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53976
---
 dlls/ntoskrnl.exe/tests/ntoskrnl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index 02af7ca230b..ff93cfc98ec 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -36,6 +36,7 @@
 #include "setupapi.h"
 #include "cfgmgr32.h"
 #include "newdev.h"
+#include "regstr.h"
 #include "dbt.h"
 #include "initguid.h"
 #include "devguid.h"
@@ -1634,7 +1635,8 @@ static void test_pnp_devices(void)
     ret = SetupDiGetDeviceRegistryPropertyA(set, &device, SPDRP_CONFIGFLAGS,
             &type, (BYTE *)&dword, sizeof(dword), NULL);
     ok(ret, "got error %#lx\n", GetLastError());
-    ok(!dword, "got flags %#lx\n", dword);
+    /* windows 7 sets CONFIGFLAG_FINISH_INSTALL; it's not clear what this means */
+    ok(!(dword & ~CONFIGFLAG_FINISH_INSTALL), "got flags %#lx\n", dword);
     ok(type == REG_DWORD, "got type %lu\n", type);
 
     ret = SetupDiGetDeviceRegistryPropertyA(set, &device, SPDRP_DEVTYPE,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1803

[PATCH 1/1] ntoskrnl/tests: Ignore CONFIGFLAG_FINISH_INSTALL on the child device.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=127568

Your paranoid android.


=== build (build log) ===

../wine/dlls/ntoskrnl.exe/tests/ntoskrnl.c:1639:19: error: ���CONFIGFLAG_FINISH_INSTALL��� undeclared (first use in this function)
Makefile:125061: recipe for target 'dlls/ntoskrnl.exe/tests/i386-windows/ntoskrnl.o' failed
Task: The exe32 Wine build failed

=== debian11 (build log) ===

../wine/dlls/ntoskrnl.exe/tests/ntoskrnl.c:1639:19: error: ���CONFIGFLAG_FINISH_INSTALL��� undeclared (first use in this function)
Task: The win32 Wine build failed

=== debian11b (build log) ===

../wine/dlls/ntoskrnl.exe/tests/ntoskrnl.c:1639:19: error: ���CONFIGFLAG_FINISH_INSTALL��� undeclared (first use in this function)
Task: The wow64 Wine build failed