[PATCH 0/1] MR6856: msi: Don't use bool as a variable name.

[Gerald Pfeifer (＠gerald)]

This is a reserved identifier in C23 and would break with GCC 15
moving to -std=gnu23 (based on C23).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6856

[PATCH 1/1] msi: Don't use bool as a variable name.

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

This is a reserved identifier in C23 and would break with GCC 15
moving to -std=gnu23 (based on C23).
---
 dlls/msi/cond.y | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/cond.y b/dlls/msi/cond.y
index b08c67447dd..49ad91ce049 100644
--- a/dlls/msi/cond.y
+++ b/dlls/msi/cond.y
@@ -123,7 +123,7 @@ static void value_free( struct value val )
     struct value value;
     LPWSTR identifier;
     INT operator;
-    BOOL bool;
+    BOOL boolean;
 }
 
 %token COND_SPACE
@@ -137,7 +137,7 @@ static void value_free( struct value val )
 
 %nonassoc COND_ERROR
 
-%type <bool> expression boolean_term boolean_factor
+%type <boolean> expression boolean_term boolean_factor
 %type <value> value
 %type <identifier> identifier
 %type <operator> operator
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6856

[PATCH 1/1] msi: Don't use bool as a variable name.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=149780

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
win.c:4070: Test failed: Expected active window 00000000024E0146, got 0000000000000000.
win.c:4071: Test failed: Expected focus window 00000000024E0146, got 0000000000000000.

Report validation errors:
uiautomationcore:uiautomation crashed (c0000005)

[PATCH 0/1] MR6856: msi: Don't use bool as a variable name. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6856