Re: [PATCH v2 0/4] MR5161: d3drm: Implement Update and related functions

[Jeffrey Smith (＠whydoubt)]

On Wed Feb 28 11:16:57 2024 +0000, Stefan Dösinger wrote:
> Suggestion: Check if *device is indeed the IDirect3DRMDevice (QI
> IID_IDirect3DRMDevice from it and compare pointers). We have cases in
> plain ddraw where callbacks and getters return the interface passed in
> instead of what the header says and applications depend on it.
> IOW, if you register the callback with
> IDirect3DRMDevice3::AddUpdateCallback you may or may not get an
> IDirect3DRMDevice3 * here.
> Interesting.  Yeah, I may add some testing for that in another MR.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5161#note_62936