Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
Loïc Rebmeister (@Fox2Code) commented about dlls/winesni.drv/dbus.c:
+ if (!(connection = p_dbus_bus_get_private( DBUS_BUS_SESSION, &error ))) { + WARN("failed to get system dbus connection: %s\n", error.message ); + p_dbus_error_free( &error ); + goto err; + } + + msg = p_dbus_message_new_method_call("org.freedesktop.DBus", + "/org/freedesktop/DBus", + "org.freedesktop.DBus", + "GetNameOwner"); + if (!msg) { + goto err; + } + + p_dbus_message_iter_init_append(msg, &args); + if (!p_dbus_message_iter_append_basic(&args, DBUS_TYPE_STRING, &watcher_interface_name )) { `watcher_interface_name` is `org.kde.StatusNotifierItem` and this code is only checking that.
Is this intentional that `org.freedesktop.StatusNotifierItem` is not checked? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2808#note_32722
participants (1)
-
Loïc Rebmeister