[PATCH 0/1] MR6232: ntdll: Use the module debug channel in virtual_map_builtin_module().

[Sven Baars (＠sbaars)]

Not sure if this is useful for anyone else, but this is the second time this warn would have saved me at least an hour.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

[PATCH 1/1] ntdll: Use the module debug channel in virtual_map_builtin_module().

[Sven Baars]

From: Sven Baars <sbaars(a)codeweavers.com>

---
 dlls/ntdll/unix/virtual.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c
index ef206d58652..0fedfe0fb1d 100644
--- a/dlls/ntdll/unix/virtual.c
+++ b/dlls/ntdll/unix/virtual.c
@@ -3428,12 +3428,12 @@ NTSTATUS virtual_map_builtin_module( HANDLE mapping, void **module, SIZE_T *size
 
     if (!image_info->wine_builtin) /* ignore non-builtins */
     {
-        WARN( "%s found in WINEDLLPATH but not a builtin, ignoring\n", debugstr_w(filename) );
+        WARN_(module)( "%s found in WINEDLLPATH but not a builtin, ignoring\n", debugstr_w(filename) );
         status = STATUS_DLL_NOT_FOUND;
     }
     else if (prefer_native && (image_info->dll_charact & IMAGE_DLLCHARACTERISTICS_PREFER_NATIVE))
     {
-        TRACE( "%s has prefer-native flag, ignoring builtin\n", debugstr_w(filename) );
+        TRACE_(module)( "%s has prefer-native flag, ignoring builtin\n", debugstr_w(filename) );
         status = STATUS_IMAGE_ALREADY_LOADED;
     }
     else
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

[PATCH 1/1] ntdll: Use the module debug channel in virtual_map_builtin_module().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147617

Your paranoid android.


=== debian11b (64 bit WoW report) ===

Report validation errors:
winmm:mci crashed (c0000008)