Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
28 May
2024
28 May
'24
9:13 p.m.
eric pouech (@epo) commented about dlls/msvcrt/undname.c:
sym->current++; break; } + /* Handle empty list in variadic template */ + if (!z_term && sym->current[0] == '$' && sym->current[1] == '$' && sym->current[2] == 'V')
that test looks very strange at that place while we already have handling of other types starting with "$$" in demangle_datatype. it calls for having a proper identification about end of list (didn't include the function arg one, but we could well do it) I think we could rather use something like the attached patch. [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70497
572
Age (days ago)
572
Last active (days ago)
0 comments
1 participants
participants (1)
-
eric pouech (@epo)