Re: [PATCH v4 0/2] MR5186: win32u: fix NtGdiExtCreateRegion implementation
Jinoh Kang (@iamahuman) commented about dlls/gdi32/tests/clipping.c:
/* Cannot be smaller than sizeof(RGNDATAHEADER) */ SetLastError(0xdeadbeef); hrgn = ExtCreateRegion(NULL, sizeof(RGNDATAHEADER) - 1, &rgn.data); - todo_wine ok(!hrgn, "ExtCreateRegion should fail\n"); - todo_wine + /* From Windows 7 returns ERROR_INVALID_PARAMETER error */ ok(GetLastError() == ERROR_INVALID_PARAMETER || - broken(GetLastError() == 0xdeadbeef), "0xdeadbeef, got %lu\n", GetLastError()); + GetLastError() == 0xdeadbeef, "ERROR_INVALID_PARAMETER (win7+) or 0xdeadbeef, got %lu\n", GetLastError());
You should keep the broken() if 0xdeadbeef is not the latest Windows behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5186#note_63259
participants (1)
-
Jinoh Kang (@iamahuman)