Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
20 Oct
2023
20 Oct
'23
1:24 a.m.
On Mon Oct 16 23:46:06 2023 +0000, Zebediah Figura wrote:
Usually enum values are capitalized; also, _t is usually reserved for typedefs. That said, do we even want this enum? Is there any instance where we shouldn't just iterate over the whole array? Two of these formats are todo, but I think something like "todo_wine_if (i == 1 || i == 8)" would be fine. Turns out that no, we don't. Every piece either should test every supported format, or uses only one format and doesn't care which, so it might as well use (or copy) the hardcoded YUY2 one. (Except the RGB8 check in init_video_mt, but I can just switch that to check something else.)
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49351
792
Age (days ago)
792
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alfred Agrell (@Alcaro)