[PATCH 0/3] MR3523: quartz: Fix some more memory leaks.
From: Sven Baars <sbaars(a)codeweavers.com> --- dlls/quartz/dsoundrender.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index 1abd4bdbcec..38a7d6f7ad7 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -536,6 +536,8 @@ static void dsound_render_destroy(struct strmbase_filter *iface) IDirectSound8_Release(filter->dsound); filter->dsound = NULL; + IUnknown_Release(filter->system_clock); + if (filter->sink.pin.peer) IPin_Disconnect(filter->sink.pin.peer); IPin_Disconnect(&filter->sink.pin.IPin_iface); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3523
From: Sven Baars <sbaars(a)codeweavers.com> --- dlls/quartz/tests/filtergraph.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index 00232ea7a52..3d6e8b80cb2 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -5076,6 +5076,8 @@ static void test_add_source_filter(void) ok(IsEqualGUID(&mt.majortype, &MEDIATYPE_Stream), "Got major type %s.\n", wine_dbgstr_guid(&mt.majortype)); ok(IsEqualGUID(&mt.subtype, &MEDIASUBTYPE_MPEG1Audio), "Got subtype %s.\n", wine_dbgstr_guid(&mt.subtype)); IFileSourceFilter_Release(filesource); + CoTaskMemFree(ret_filename); + FreeMediaType(&mt); hr = IFilterGraph2_AddSourceFilter(graph, filename, L"test", &filter2); ok(hr == S_OK, "Got hr %#lx.\n", hr); @@ -5115,6 +5117,8 @@ static void test_add_source_filter(void) ok(IsEqualGUID(&mt.majortype, &MEDIATYPE_Stream), "Got major type %s.\n", wine_dbgstr_guid(&mt.majortype)); ok(IsEqualGUID(&mt.subtype, &MEDIATYPE_Midi), "Got subtype %s.\n", wine_dbgstr_guid(&mt.subtype)); IFileSourceFilter_Release(filesource); + CoTaskMemFree(ret_filename); + FreeMediaType(&mt); hr = IFilterGraph2_RemoveFilter(graph, filter); ok(hr == S_OK, "Got hr %#lx.\n", hr); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3523
From: Sven Baars <sbaars(a)codeweavers.com> --- libs/strmbase/seeking.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/strmbase/seeking.c b/libs/strmbase/seeking.c index b3991f0a5b3..91e9ccedfb4 100644 --- a/libs/strmbase/seeking.c +++ b/libs/strmbase/seeking.c @@ -56,6 +56,7 @@ HRESULT strmbase_seeking_init(SourceSeeking *pSeeking, const IMediaSeekingVtbl * void strmbase_seeking_cleanup(SourceSeeking *seeking) { + seeking->cs.DebugInfo->Spare[0] = 0; DeleteCriticalSection(&seeking->cs); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3523
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=135740 Your paranoid android. === build (build log) === /home/winetest/tools/testbot/var/wine-exe32/../wine/dlls/quartz/tests/filtergraph.c:5080: undefined reference to `FreeMediaType' /usr/bin/i686-w64-mingw32-ld: /home/winetest/tools/testbot/var/wine-exe32/../wine/dlls/quartz/tests/filtergraph.c:5121: undefined reference to `FreeMediaType' collect2: error: ld returned 1 exit status Task: The exe32 Wine build failed === debian11 (build log) === /home/winetest/tools/testbot/var/wine-win32/../wine/dlls/quartz/tests/filtergraph.c:5080: undefined reference to `FreeMediaType' /usr/bin/i686-w64-mingw32-ld: /home/winetest/tools/testbot/var/wine-win32/../wine/dlls/quartz/tests/filtergraph.c:5121: undefined reference to `FreeMediaType' /home/winetest/tools/testbot/var/wine-win32/../wine/dlls/quartz/tests/filtergraph.c:5080: undefined reference to `FreeMediaType' /usr/bin/i686-w64-mingw32-ld: /home/winetest/tools/testbot/var/wine-win32/../wine/dlls/quartz/tests/filtergraph.c:5121: undefined reference to `FreeMediaType' collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status Task: The win32 Wine build failed === debian11b (build log) === /home/winetest/tools/testbot/var/wine-wow32/../wine/dlls/quartz/tests/filtergraph.c:5080: undefined reference to `FreeMediaType' /usr/bin/i686-w64-mingw32-ld: /home/winetest/tools/testbot/var/wine-wow32/../wine/dlls/quartz/tests/filtergraph.c:5121: undefined reference to `FreeMediaType' /home/winetest/tools/testbot/var/wine-wow32/../wine/dlls/quartz/tests/filtergraph.c:5080: undefined reference to `FreeMediaType' /usr/bin/i686-w64-mingw32-ld: /home/winetest/tools/testbot/var/wine-wow32/../wine/dlls/quartz/tests/filtergraph.c:5121: undefined reference to `FreeMediaType' collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status Task: The wow32 Wine build failed
participants (3)
-
Marvin -
Sven Baars -
Sven Baars (＠sbaars)