[PATCH v2 0/2] MR9167: Use %I64u instead of %llu.
Fixes compiler warnings on older systems. -- v2: winhttp: Use %I64u instead of %llu. mmdevapi/tests: Use %I64u instead of %llu. https://gitlab.winehq.org/wine/wine/-/merge_requests/9167
From: Sven Baars <sbaars(a)codeweavers.com> --- dlls/mmdevapi/tests/capture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c index 8963ee97e05..842ea319ff5 100644 --- a/dlls/mmdevapi/tests/capture.c +++ b/dlls/mmdevapi/tests/capture.c @@ -305,7 +305,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) /* GetBufferSize is not a multiple of the period size! */ hr = IAudioClient_GetBufferSize(ac, &buffer_size); ok(hr == S_OK, "GetBufferSize failed: %08lx\n", hr); - trace("GetBufferSize %u period size %llu\n", buffer_size, period); + trace("GetBufferSize %u period size %I64u\n", buffer_size, period); hr = IAudioClient_Start(ac); ok(hr == S_OK, "Start on a stopped stream returns %08lx\n", hr); @@ -320,7 +320,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) * packets to arrive concurrently. */ hr = IAudioClient_GetCurrentPadding(ac, &padding); ok(hr == S_OK, "GetCurrentPadding returns %08lx\n", hr); - ok(padding <= 2 * period, "GetCurrentPadding %u is larger then twice the period %llu\n", + ok(padding <= 2 * period, "GetCurrentPadding %u is larger then twice the period %I64u\n", padding, period); todo_wine @@ -337,7 +337,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) hr = IAudioClient_GetCurrentPadding(ac, &padding); ok(hr == S_OK, "GetCurrentPadding returns %08lx\n", hr); - ok(padding <= 2 * period, "GetCurrentPadding %u is larger then twice the period %llu\n", + ok(padding <= 2 * period, "GetCurrentPadding %u is larger then twice the period %I64u\n", padding, period); ok(!packets_data.discontinuity_at_0, "Discontinuity at first packet\n"); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9167
From: Sven Baars <sbaars(a)codeweavers.com> --- dlls/winhttp/request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 777e3680f42..60aff3ee4ba 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -2011,7 +2011,7 @@ static DWORD read_data( struct request *request, void *buffer, DWORD size, DWORD if (request->read_chunked && !request->read_chunked_size) ret = refill_buffer( request, async ); done: - TRACE( "retrieved %u bytes (%llu/%llu)\n", bytes_read, request->content_read, request->content_length ); + TRACE( "retrieved %u bytes (%I64u/%I64u)\n", bytes_read, request->content_read, request->content_length ); if (end_of_read_data( request )) finished_reading( request ); if (async) { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9167
On Tue Oct 14 15:00:29 2025 +0000, Paul Gofman wrote:
I think we can now use %I64u (%#I64x, %I64d) for 64 bit values in the PE code (and %Iu for SIZE_T and friends). Ah, thanks! I'll keep that in mind for future fixes as well.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9167#note_118522
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9167
participants (3)
-
Huw Davies (@huw) -
Sven Baars -
Sven Baars (@sbaars)