Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty

[Zhiyi Zhang (＠zhiyi)]

On Wed Oct 11 01:39:28 2023 +0000, Zhiyi Zhang wrote:
> In that case, you should implement them. For ShouldAppsUseDarkMode(),
> there is a recent MR at
> https://gitlab.winehq.org/wine/wine/-/merge_requests/3959 that
> implements ShouldSystemUseDarkMode(). I think ShouldAppsUseDarkMode() is
> similar and uses the AppsUseLightTheme registry key. For
> AllowDarkModeForWindow() and SetPreferredAppMode(), they can be
> implemented as stubs for the moment. I also came across
> https://gist.github.com/rounk-ctrl/b04e5622e30e0d62956870d5c22b7017
> which lists their usage.
> It looks to me that AllowDarkModeForWindow() and SetPreferredAppMode() set window-specific properties so that dark mode can be enabled/disabled for individual windows. And ShouldAppsUseDarkMode() should consider that. For the moment, returning the AppsUseLightTheme value for ShouldAppsUseDarkMode() is probably enough.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48281