[PATCH v3 0/2] MR7827: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message.

[Byeongsik Jeon (＠bsjeon)]

This patch fixes a Japanese input issue in MS Office Visual Basic and Mery text
editor ime inline mode. The following was considered:

  1. Japanese ime: the result string message is always placed between
     WM_IME_STARTCOMPOSITION and WM_IME_ENDCOMPOSITION. Currently in Wine,
     the result string message follows WM_IME_ENDCOMPOSITION.

     dlls/imm32/tests/imm32.c::test_nihongo_no().

  2. Chinese ime: same as Japanese ime.

  3. Korean ime: mostly the same, but there are some cases where it is not
     (e.g. CPS_COMPLETE, 'r-k-RETURN'). However, I haven't found any problem
     even if it behave like Japanese ime message order.

  3. zero-length preedit string: as in MR !3115 commit d1f9aae, the message
     followed by WM_IME_ENDCOMPOSITION. Currently in Wine, it is associated
     with WM_IME_STARTCOMPOSITION.

  4. zero-length result string: ignore.

--
  v3: winewayland: Use an empty string to clear the composition string.
      imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

[PATCH v3 1/2] imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message.

[Byeongsik Jeon]

From: Byeongsik Jeon <bsjeon(a)hanmail.net>

This patch fixes a Japanese input issue in MS Office Visual Basic and Mery text
editor ime inline mode. The following was considered:

  1. Japanese ime: the result string message is always placed between
     WM_IME_STARTCOMPOSITION and WM_IME_ENDCOMPOSITION. Currently in Wine,
     the result string message follows WM_IME_ENDCOMPOSITION.

     dlls/imm32/tests/imm32.c::test_nihongo_no().

  2. Chinese ime: same as Japanese ime.

  3. Korean ime: mostly the same, but there are some cases where it is not
     (e.g. CPS_COMPLETE, 'r-k-RETURN'). However, I haven't found any problem
     even if it behave like Japanese ime message order.

  3. zero-length preedit string: as in MR !3115 commit d1f9aae, the message
     followed by WM_IME_ENDCOMPOSITION. Currently in Wine, it is associated
     with WM_IME_STARTCOMPOSITION.

  4. zero-length result string: ignore.
---
 dlls/imm32/ime.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/dlls/imm32/ime.c b/dlls/imm32/ime.c
index d7ffc3de115..1487c847e00 100644
--- a/dlls/imm32/ime.c
+++ b/dlls/imm32/ime.c
@@ -561,14 +561,17 @@ UINT WINAPI ImeToAsciiEx( UINT vkey, UINT vsc, BYTE *state, TRANSMSGLIST *msgs,
     if (status) WARN( "WINE_IME_TO_ASCII_EX returned status %#lx\n", status );
     else
     {
-        TRANSMSG status_msg = {.message = ime_set_composition_status( himc, !!compstr->dwCompStrOffset )};
-        if (status_msg.message) msgs->TransMsg[count++] = status_msg;
+        if (compstr->dwCompStrOffset || compstr->dwResultStrLen)
+        {
+            TRANSMSG msg = {.message = ime_set_composition_status( himc, TRUE )};
+            if (msg.message == WM_IME_STARTCOMPOSITION) msgs->TransMsg[count++] = msg;
+        }
 
-        if (compstr->dwResultStrOffset)
+        if (compstr->dwResultStrLen)
         {
             const WCHAR *result = (WCHAR *)((BYTE *)compstr + compstr->dwResultStrOffset);
             TRANSMSG msg = {.message = WM_IME_COMPOSITION, .wParam = result[0], .lParam = GCS_RESULTSTR};
-            if (compstr->dwResultClauseOffset) msg.lParam |= GCS_RESULTCLAUSE;
+            if (compstr->dwResultClauseLen) msg.lParam |= GCS_RESULTCLAUSE;
             msgs->TransMsg[count++] = msg;
         }
 
@@ -582,6 +585,12 @@ UINT WINAPI ImeToAsciiEx( UINT vkey, UINT vsc, BYTE *state, TRANSMSGLIST *msgs,
             msgs->TransMsg[count++] = msg;
         }
 
+        if (!compstr->dwCompStrLen)
+        {
+            TRANSMSG msg = {.message = ime_set_composition_status( himc, FALSE )};
+            if (msg.message == WM_IME_ENDCOMPOSITION) msgs->TransMsg[count++] = msg;
+        }
+
         if (!key_consumed)
         {
             TRANSMSG msg = {.message = WM_IME_KEYDOWN, .wParam = vkey, .lParam = vsc};
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

[PATCH v3 2/2] winewayland: Use an empty string to clear the composition string.

[Byeongsik Jeon]

From: Byeongsik Jeon <bsjeon(a)hanmail.net>

---
 dlls/winewayland.drv/wayland_text_input.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/winewayland.drv/wayland_text_input.c b/dlls/winewayland.drv/wayland_text_input.c
index f8df5fe09cb..bb974cd06fd 100644
--- a/dlls/winewayland.drv/wayland_text_input.c
+++ b/dlls/winewayland.drv/wayland_text_input.c
@@ -35,6 +35,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(imm);
 
 static void post_ime_update(HWND hwnd, UINT cursor_pos, WCHAR *comp_str, WCHAR *result_str)
 {
+    /* Windows uses an empty string to clear the composition string. */
+    if (!comp_str && !result_str) comp_str = (WCHAR *)L"";
+
     NtUserMessageCall(hwnd, WINE_IME_POST_UPDATE, cursor_pos, (LPARAM)comp_str, result_str,
             NtUserImeDriverCall, FALSE);
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

[Byeongsik Jeon (＠bsjeon)]

v3: revert to v1, and use dwCompStrOffset in the start_composition part.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7827#note_101227

[PATCH v3 0/2] MR7827: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7827