[PATCH 0/1] MR2376: wintypes: Stub RoIsApiContractMajorVersionPresent().

[Daniel Tang (＠danielzgtg)]

This is one of the stubs required for MS Office 365.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2376

[PATCH 1/1] wintypes: Stub RoIsApiContractMajorVersionPresent().

[Daniel Tang]

From: Daniel Tang <danielzgtg.opensource(a)gmail.com>

---
 dlls/wintypes/main.c        | 7 +++++++
 dlls/wintypes/wintypes.spec | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/dlls/wintypes/main.c b/dlls/wintypes/main.c
index 74eda4af5ce..40bf35ecb8d 100644
--- a/dlls/wintypes/main.c
+++ b/dlls/wintypes/main.c
@@ -355,6 +355,13 @@ HRESULT WINAPI DllGetActivationFactory(HSTRING classid, IActivationFactory **fac
     return S_OK;
 }
 
+HRESULT WINAPI RoIsApiContractMajorVersionPresent(const WCHAR *name, UINT16 major, BOOL *result)
+{
+    // For some reason MS Office crashes if a logging statement is added here
+    *result = FALSE;
+    return S_OK;
+}
+
 HRESULT WINAPI RoResolveNamespace(HSTRING name, HSTRING windowsMetaDataDir,
                                   DWORD packageGraphDirsCount, const HSTRING *packageGraphDirs,
                                   DWORD *metaDataFilePathsCount, HSTRING **metaDataFilePaths,
diff --git a/dlls/wintypes/wintypes.spec b/dlls/wintypes/wintypes.spec
index 305344fef42..086332e0d69 100644
--- a/dlls/wintypes/wintypes.spec
+++ b/dlls/wintypes/wintypes.spec
@@ -5,7 +5,7 @@
 @ stub RoCreatePropertySetSerializer
 @ stub RoGetBufferMarshaler
 @ stub RoGetMetaDataFile
-@ stub RoIsApiContractMajorVersionPresent
+@ stdcall RoIsApiContractMajorVersionPresent(wstr long ptr)
 @ stub RoIsApiContractPresent
 @ stub RoParseTypeName
 @ stdcall RoResolveNamespace(ptr ptr long ptr ptr ptr ptr ptr)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2376

[PATCH 1/1] wintypes: Stub RoIsApiContractMajorVersionPresent().

[Jactry Zeng]

On Sat, Mar 11, 2023 at 1:26 PM Daniel Tang <wine(a)gitlab.winehq.org> wrote:
> From: Daniel Tang <danielzgtg.opensource(a)gmail.com>
>
> +HRESULT WINAPI comments(const WCHAR *name, UINT16 major, BOOL *result)
> +{
> +    // For some reason MS Office crashes if a logging statement is added

here

This is interesting, but I think it will be better to dig a little bit
deeper and figure out its root.
Other than that, please use C89 standard comments.


Thanks