[PATCH v2 0/1] MR1123: winetest: Let the get_subtests() caller report errors.

[Francois Gouget (＠fgouget)]

--
  v2: winetest: Let the get_subtests() caller report errors.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1123

[PATCH v2 1/1] winetest: Let the get_subtests() caller report errors.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

The caller already analyses get_subtests() errors and provides
a detailed error message in the information section of the report
so the report(R_ERROR) pop up / stderr message is redundant.
---
 programs/winetest/main.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/programs/winetest/main.c b/programs/winetest/main.c
index c24af4952c7..74b596b237b 100644
--- a/programs/winetest/main.c
+++ b/programs/winetest/main.c
@@ -815,12 +815,8 @@ get_subtests (const char *tempdir, struct wine_test *test, LPSTR res_name)
 
     if (status)
     {
-        if (status == -2)
-            report (R_ERROR, "Cannot run %s error %u", test->exename, err);
-        else
-            err = status;
         close_temp_file( subname, subfile );
-        return err;
+        return status == -2 ? err : status;
     }
 
     buffer = flush_temp_file( subname, subfile, &total );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1123

[PATCH v2 1/1] winetest: Let the get_subtests() caller report errors.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125204

Your paranoid android.


=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24732.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24732.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24732.

[Francois Gouget (＠fgouget)]

v2: Fixed the author.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1123#note_11530