Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c:
> DestroyWindow(hwnd);
>  }
>
> +static void test_ShouldSystemUseDarkMode(void)

I think these tests might be a bit too much. I like the initial version that uses RegGetValueA() and confirms the registry value is the opposite of the ShouldSystemUseDarkMode. With some checks for the last error code and I think that's enough. These newly added tests confirm caching for ShouldSystemUseDarkMode() and that's good. However, ShouldSystemUseDarkMode() still need to query the registry key so it's not that useful.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47270