[PATCH 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)

[Fabian Maurer (＠DarkShadow44)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

[PATCH 1/1] winegstreamer: In error case don't dereference null pointer (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

---
 dlls/winegstreamer/wg_transform.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/winegstreamer/wg_transform.c b/dlls/winegstreamer/wg_transform.c
index ab5ce381fc5..536ef0af143 100644
--- a/dlls/winegstreamer/wg_transform.c
+++ b/dlls/winegstreamer/wg_transform.c
@@ -953,10 +953,11 @@ NTSTATUS wg_transform_notify_qos(void *args)
         GST_LOG("Ignoring QoS event.");
         return S_OK;
     }
-    if (!(event = gst_event_new_qos(params->underflow ? GST_QOS_TYPE_UNDERFLOW : GST_QOS_TYPE_OVERFLOW,
-            params->proportion, diff, stream_time)))
+    event = gst_event_new_qos(params->underflow ? GST_QOS_TYPE_UNDERFLOW : GST_QOS_TYPE_OVERFLOW, params->proportion, diff, stream_time);
+    if (event)
+        push_event(transform->my_sink, event);
+    else
         GST_ERROR("Failed to create QOS event.");
-    push_event(transform->my_sink, event);
 
     return S_OK;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

[Zebediah Figura (＠zfigura)]

I'll accept this, but this kind of change feels like a waste of time.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4665#note_55632

[Fabian Maurer (＠DarkShadow44)]

On Sun Dec 10 19:32:46 2023 +0000, Zebediah Figura wrote:
> I'll accept this, but this kind of change feels like a waste of time.
> How so, shouldn't we avoid crashes even in error cases?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4665#note_55633

[Zebediah Figura (＠zfigura)]

On Sun Dec 10 19:32:46 2023 +0000, Fabian Maurer wrote:
> How so, shouldn't we avoid crashes even in error cases?
> If this really fails then it's only a symptom of some other problem.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4665#note_55634

[PATCH 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity) - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4665