[PATCH 0/1] MR4766: msi: Fix a memory leak (Coverity).

[Zhiyi Zhang (＠zhiyi)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4766

[PATCH 1/1] msi: Fix a memory leak (Coverity).

[Zhiyi Zhang]

From: Zhiyi Zhang <zzhang(a)codeweavers.com>

---
 dlls/msi/action.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 575af431854..20da818e686 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -5263,9 +5263,13 @@ static UINT ACTION_ResolveSource(MSIPACKAGE* package)
             MSI_RecordSetStringW(record, 0, NULL);
             rc = MSI_ProcessMessage(package, INSTALLMESSAGE_ERROR, record);
             if (rc == IDCANCEL)
+            {
+                msiobj_release(&record->hdr);
                 return ERROR_INSTALL_USEREXIT;
+            }
             attrib = GetFileAttributesW(package->db->path);
         }
+        msiobj_release(&record->hdr);
         rc = ERROR_SUCCESS;
     }
     else
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4766

[PATCH 1/1] msi: Fix a memory leak (Coverity).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=141527

Your paranoid android.


=== debian11b (64 bit WoW report) ===

qasf:
asfreader.c:947: Test failed: blocking 0: Got hr 0x80040216.
Unhandled exception: page fault on read access to 0xffffffffffffffff in 64-bit code (0x00000000402cef).

[PATCH 0/1] MR4766: msi: Fix a memory leak (Coverity). - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4766