[PATCH 0/1] MR7078: user32: copy the clipboard format iterator's position when cloning it

[Damjan Jovanovic (＠dj)]

Fixes a bug in the clipboard's IEnumFORMATETC::Clone(), where cloned iterators start at the beginning, instead of at the position of the original iterator.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7078

[PATCH 1/1] user32: copy the clipboard format iterator's position when cloning it

[Damjan Jovanovic]

From: Damjan Jovanovic <damjan.jov(a)gmail.com>

---
 dlls/user32/clipboard.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/user32/clipboard.c b/dlls/user32/clipboard.c
index 55d410c34ea..a78a623cf68 100644
--- a/dlls/user32/clipboard.c
+++ b/dlls/user32/clipboard.c
@@ -766,9 +766,13 @@ static HRESULT format_iterator_create( IDataObject *object, IEnumFORMATETC **out
 
 static HRESULT WINAPI format_iterator_Clone( IEnumFORMATETC *iface, IEnumFORMATETC **out )
 {
+    HRESULT hr;
     struct format_iterator *iterator = format_iterator_from_IEnumFORMATETC( iface );
     TRACE( "iterator %p, out %p\n", iterator, out );
-    return format_iterator_create( iterator->object, out );
+    hr = format_iterator_create( iterator->object, out );
+    if (SUCCEEDED(hr))
+        format_iterator_from_IEnumFORMATETC( *out )->entry = iterator->entry;
+    return hr;
 }
 
 static const IEnumFORMATETCVtbl format_iterator_vtbl =
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7078

[PATCH 1/1] user32: copy the clipboard format iterator's position when cloning it

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150564

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000011E00EA, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[Jinoh Kang (＠iamahuman)]

This would need tests.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7078#note_91183