[PATCH 0/1] MR4719: imm32/tests: Fix HKL comparison when cleaning up preload list.
From: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/imm32/tests/imm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c index 07caa054357..66ebbfd161d 100644 --- a/dlls/imm32/tests/imm32.c +++ b/dlls/imm32/tests/imm32.c @@ -3721,7 +3721,7 @@ static void ime_cleanup( HKL hkl, BOOL free ) { value_len = ARRAY_SIZE(value); buffer_len = sizeof(buffer); - if (hkl != UlongToHandle( wcstoul( buffer, NULL, 16 ) )) continue; + if (HandleToUlong( hkl ) != wcstoul( buffer, NULL, 16 )) continue; ret = RegDeleteValueW( hkey, value ); ok( !ret, "RegDeleteValueW returned %#lx, error %lu\n", ret, GetLastError() ); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4719
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=141377 Your paranoid android. === w10pro64_ja (64 bit report) === imm32: imm32.c:7632: Test failed: 0 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_STARTCOMPOSITION, wparam 0, lparam 0, comp L"", result L"" imm32.c:7632: Test failed: 1 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0xff4e, lparam 0x1b9, comp L"\ff4e", result L"" imm32.c:7632: Test failed: 2 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306b, lparam 0x1b9, comp L"\306b", result L"" imm32.c:7632: Test failed: 3 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306b, lparam 0x1b9, comp L"\306b\ff48", result L"" imm32.c:7632: Test failed: 4 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306b, lparam 0x1b9, comp L"\306b\307b", result L"" imm32.c:7632: Test failed: 5 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306b, lparam 0x1b9, comp L"\306b\307b\ff4e", result L"" imm32.c:7632: Test failed: 6 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306b, lparam 0x1b9, comp L"\306b\307b\3093\ff47", result L"" imm32.c:7632: Test failed: 7 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306b, lparam 0x1b9, comp L"\306b\307b\3093\3054", result L"" imm32.c:7632: Test failed: 8 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x65e5, lparam 0x1b9, comp L"\65e5\672c\8a9e", result L"" imm32.c:7632: Test failed: 9 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x65e5, lparam 0x1e00, comp L"", result L"\65e5\672c\8a9e" imm32.c:7632: Test failed: 10 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_CHAR, wparam 0x65e5, lparam 0x1, comp L"", result L"" imm32.c:7632: Test failed: 11 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_CHAR, wparam 0x672c, lparam 0x1, comp L"", result L"" imm32.c:7632: Test failed: 12 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_CHAR, wparam 0x8a9e, lparam 0x1, comp L"", result L"" imm32.c:7632: Test failed: 13 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_ENDCOMPOSITION, wparam 0, lparam 0, comp L"", result L"" imm32.c:7632: Test failed: 14 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_STARTCOMPOSITION, wparam 0, lparam 0, comp L"", result L"" imm32.c:7632: Test failed: 15 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0xff4e, lparam 0x1b9, comp L"\ff4e", result L"" imm32.c:7632: Test failed: 16 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306e, lparam 0x1b9, comp L"\306e", result L"" imm32.c:7632: Test failed: 17 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_COMPOSITION, wparam 0x306e, lparam 0x1e00, comp L"", result L"\306e" imm32.c:7632: Test failed: 18 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_CHAR, wparam 0x306e, lparam 0x1, comp L"", result L"" imm32.c:7632: Test failed: 19 (missing): hkl 0000000004110411, himc 0000000000040089, MSG_TEST_WIN msg WM_IME_ENDCOMPOSITION, wparam 0, lparam 0, comp L"", result L""
participants (2)
-
Marvin -
Rémi Bernon