[PATCH 0/1] MR5014: wbemprox: Add property 'Caption' to Win32_PnPEntity.

[Louis Lenders (＠xe)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56291

Note: On windows powershell something like "Get-WmiObject win32_pnpentity -property name"
gives exact same results as "Get-WmiObject win32_pnpentity -property caption" so
I used same string for caption as for name in the patch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5014

[PATCH 1/1] wbemprox: Add property 'Caption' to Win32_PnPEntity.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56291

Note: On windows powershell something like "Get-WmiObject win32_pnpentity -property name"
gives exact same results as "Get-WmiObject win32_pnpentity -property caption" so
I used identical string for caption in the patch.
---
 dlls/wbemprox/builtin.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c
index 31df1f5c920..38e6893792b 100644
--- a/dlls/wbemprox/builtin.c
+++ b/dlls/wbemprox/builtin.c
@@ -300,6 +300,7 @@ static const struct column col_physicalmemory[] =
 };
 static const struct column col_pnpentity[] =
 {
+    { L"Caption",              CIM_STRING },
     { L"DeviceId",             CIM_STRING|COL_FLAG_DYNAMIC },
     { L"Manufacturer",         CIM_STRING },
     { L"Name",                 CIM_STRING },
@@ -753,6 +754,7 @@ struct record_physicalmemory
 };
 struct record_pnpentity
 {
+    const WCHAR *caption;
     const WCHAR *device_id;
     const WCHAR *manufacturer;
     const WCHAR *name;
@@ -3178,6 +3180,7 @@ static enum fill_status fill_pnpentity( struct table *table, const struct expr *
         if (SetupDiGetDeviceInstanceIdW( device_info_set, &devinfo, device_id,
                     ARRAY_SIZE(device_id), NULL ))
         {
+            rec->caption = L"Wine PnP Device";
             rec->device_id = wcsdup( device_id );
             rec->manufacturer = L"The Wine Project";
             rec->name = L"Wine PnP Device";
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5014

[PATCH 1/1] wbemprox: Add property 'Caption' to Win32_PnPEntity.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=142746

Your paranoid android.


=== debian11b (64 bit WoW report) ===

wmvcore:
wmvcore.c:3747: Test failed: Output 0: Got hr 0xc00d0041.

[PATCH 0/1] MR5014: wbemprox: Add property 'Caption' to Win32_PnPEntity. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5014