[PATCH v2 0/1] MR1130: wbemprox: Fix string length in get_value_bstr().

[Paul Gofman (＠gofman)]

Currently the resulting string is missing closing quote.

--
  v2: wbemprox: Fix string length in get_value_bstr().
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1130

[PATCH v2 1/1] wbemprox: Fix string length in get_value_bstr().

[Paul Gofman]

From: Paul Gofman <pgofman(a)codeweavers.com>

---
 dlls/wbemprox/table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c
index 34b09bc872f..ab386efa06b 100644
--- a/dlls/wbemprox/table.c
+++ b/dlls/wbemprox/table.c
@@ -178,7 +178,7 @@ BSTR get_value_bstr( const struct table *table, UINT row, UINT column )
         if (!val) return NULL;
         len = lstrlenW( (const WCHAR *)(INT_PTR)val ) + 2;
         if (!(ret = SysAllocStringLen( NULL, len ))) return NULL;
-        swprintf( ret, len, L"\"%s\"", (const WCHAR *)(INT_PTR)val );
+        swprintf( ret, len + 1, L"\"%s\"", (const WCHAR *)(INT_PTR)val );
         return ret;
 
     case CIM_SINT16:
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1130

[PATCH v2 1/1] wbemprox: Fix string length in get_value_bstr().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125266

Your paranoid android.


=== debian11 (build log) ===

Task: Could not create the win32 wineprefix: Failed to disable the crash dialogs: 
Task: WineTest did not produce the win32 report