[PATCH 0/1] MR2970: wusa: Fix double free on error path in read_update_package (scan-build).

[Alex Henrie (＠alexhenrie)]

If read_identity returns FALSE, it has already called clear_identity.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2970

[PATCH 1/1] wusa: Fix double free on error path in read_update_package (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

If read_identity returns FALSE, it has already called clear_identity.
---
 programs/wusa/manifest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/wusa/manifest.c b/programs/wusa/manifest.c
index 620da4fc63b..83d4125133f 100644
--- a/programs/wusa/manifest.c
+++ b/programs/wusa/manifest.c
@@ -587,7 +587,7 @@ static BOOL read_update_package(IXMLDOMElement *child, WCHAR *tagname, void *con
             list_add_tail(update_list, &entry->entry);
             return TRUE;
         }
-        free_dependency(entry);
+        free(entry);
     }
 
     return FALSE;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2970

[PATCH 0/1] MR2970: wusa: Fix double free on error path in read_update_package (scan-build). - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2970